Classify MySQL LinearRing WKB parse error as unsupported datatype#4274
Merged
Conversation
Match the specific geom-library failure "Points of LinearRing do not form a closed linestring" produced via processGeometryData and surface it to the user as ErrorUnsupportedDatatype with code UNSUPPORTED_GEOMETRY_LINEAR_RING_NOT_CLOSED. Other "failed to parse geometry WKB" errors continue to fall through so we can spot unclassified cases. Resolves DBI-732 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Jeremyyang920
commented
May 5, 2026
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
ilidemi
reviewed
May 5, 2026
❌ 3 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Contributor
🔄 Flaky Test DetectedAnalysis: Both failing matrix jobs hit timing-related issues: the ✅ Automatically retrying the workflow |
Replace string-match classification with a MySQLGeometryParseError wrapper so the MySQL source is encoded in the type. Only classify the known "LinearRing not closed" message; other go-geos parse failures fall through to ErrorOther so they remain visible in telemetry. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ilidemi
approved these changes
May 5, 2026
ilidemi
left a comment
ilidemi
left a comment
Contributor
There was a problem hiding this comment.
Nicely done with the negative unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Match the specific geom-library failure "Points of LinearRing do not form a closed linestring" produced via processGeometryData and surface it to the user as ErrorUnsupportedDatatype with code UNSUPPORTED_GEOMETRY_LINEAR_RING_NOT_CLOSED. Other "failed to parse geometry WKB" errors continue to fall through so we can spot unclassified cases.
Resolves DBI-732